Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): add Radix UI example #41169

Merged
merged 14 commits into from Oct 5, 2022
Merged

chore(examples): add Radix UI example #41169

merged 14 commits into from Oct 5, 2022

Conversation

pedro757
Copy link
Contributor

@pedro757 pedro757 commented Oct 4, 2022

fixes #40072

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Oct 4, 2022
@balazsorban44 balazsorban44 changed the title add Radix-UI example chore(examples): add Radix UI example Oct 5, 2022
balazsorban44
balazsorban44 previously approved these changes Oct 5, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I applied some suggestions to better conform with our other examples and to follow our example guidelines https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md

@kodiakhq kodiakhq bot merged commit 6e17169 into vercel:canary Oct 5, 2022
BowlingX pushed a commit to BowlingX/next.js that referenced this pull request Oct 5, 2022
fixes vercel#40072 

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
fixes vercel#40072 

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EXAMPLE] Add example NextJS with Radix-UI
4 participants