Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade React experimental #41222

Merged
merged 1 commit into from Oct 6, 2022
Merged

Upgrade React experimental #41222

merged 1 commit into from Oct 6, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Oct 6, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Oct 6, 2022
@ijjk
Copy link
Member

ijjk commented Oct 6, 2022

Failing test suites

Commit: f783c76

pnpm testheadless test/integration/amphtml/test/index.test.js

  • AMP Usage > AMP dev mode > should detect changes to component and refresh an AMP page
Expand output

● AMP Usage › AMP dev mode › should detect changes to component and refresh an AMP page

TIMED OUT: /hello/

hi

  519 |
  520 |   if (hardError) {
> 521 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  522 |   }
  523 |   return false
  524 | }

  at check (lib/next-test-utils.js:521:11)
  at Object.<anonymous> (integration/amphtml/test/index.test.js:388:7)

Read more about building and testing Next.js in contributing.md.

@shuding shuding merged commit c6dc62e into vercel:canary Oct 6, 2022
@shuding shuding deleted the shu/7v5k branch October 6, 2022 16:06
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
<!--
Thanks for opening a PR! Your contribution is much appreciated.
To make sure your PR is handled as smoothly as possible we request that
you follow the checklist sections below.
Choose the right checklist for the change that you're making:
-->

## Bug

- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`

## Feature

- [ ] Implements an existing feature request or RFC. Make sure the
feature request has been accepted for implementation before opening a
PR.
- [ ] Related issues linked using `fixes #number`
- [ ] Integration tests added
- [ ] Documentation added
- [ ] Telemetry added. In case of a feature if it's used or not.
- [ ] Errors have a helpful link attached, see `contributing.md`

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing
doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants