Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix middleware rewrite for _next/data #41341

Merged
merged 2 commits into from Oct 11, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Oct 11, 2022

x-ref: slack thread

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

@ijjk ijjk added created-by: Next.js team PRs by the Next.js team type: next labels Oct 11, 2022
@ijjk ijjk marked this pull request as ready for review October 11, 2022 19:19
@ijjk ijjk merged commit 3188658 into vercel:canary Oct 11, 2022
@ijjk ijjk deleted the fix/middleware-next-data-rewrite branch October 11, 2022 19:23
@ijjk ijjk mentioned this pull request Oct 11, 2022
3 tasks
ijjk added a commit that referenced this pull request Oct 11, 2022
Follow-up to #41341 this fixes a
related issue with the URL normalizing in middleware and updates the
regression tests.

x-ref: [slack
thread](https://vercel.slack.com/archives/C01224Q5M99/p1665161421775079?thread_ts=1664536480.045539&cid=C01224Q5M99)

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
x-ref: [slack
thread](https://vercel.slack.com/archives/C01224Q5M99/p1665161421775079?thread_ts=1664536480.045539&cid=C01224Q5M99)

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
Follow-up to vercel#41341 this fixes a
related issue with the URL normalizing in middleware and updates the
regression tests.

x-ref: [slack
thread](https://vercel.slack.com/archives/C01224Q5M99/p1665161421775079?thread_ts=1664536480.045539&cid=C01224Q5M99)

## Bug

- [x] Related issues linked using `fixes #number`
- [x] Integration tests added
- [ ] Errors have a helpful link attached, see `contributing.md`
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants