Update node-module-in-edge-runtime.md #41375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leerob
requested review from
timneutkens,
ijjk,
shuding,
styfle,
huozhi,
padmaia and
balazsorban44
as code owners
styfle
reviewed
Oct 12, 2022
| ``` | ||
|
|
||
| Dynamic imports in unreachable code path is also supported. | ||
| > **Note:** You can import Node.js modules as long as they are not used. |
There was a problem hiding this comment.
Do we need to clarify why you would want to import something unused?
styfle
reviewed
Oct 12, 2022
styfle
previously approved these changes
Oct 12, 2022
ijjk
previously approved these changes
Oct 12, 2022
ijjk
approved these changes
Oct 13, 2022
Kikobeats
pushed a commit
to Kikobeats/next.js
that referenced
this pull request
Oct 24, 2022
To be a bit more clear. Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be a bit more clear.