Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added example with salesforce commerce cloud #41376

Merged
merged 15 commits into from Oct 13, 2022
Merged

Added example with salesforce commerce cloud #41376

merged 15 commits into from Oct 13, 2022

Conversation

Nutlope
Copy link
Contributor

@Nutlope Nutlope commented Oct 13, 2022

Adding a Next.js example with Salesforce Commerce Cloud

@ijjk ijjk added the examples Issue/PR related to examples label Oct 13, 2022
@Nutlope
Copy link
Contributor Author

Nutlope commented Oct 13, 2022

Anyone know how to fix this error?

CleanShot 2022-10-12 at 20 12 30@2x

leerob
leerob previously approved these changes Oct 13, 2022
View reviewed changes
balazsorban44
balazsorban44 requested changes Oct 13, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some feedback. Could you convert the example to TypeScript? (I also did not see the tsconfig.json file, make sure to add it.)

Also, could you go over the criteria here: https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md

examples/with-sfcc/.example.env Outdated Show resolved Hide resolved
examples/with-sfcc/.gitignore Outdated Show resolved Hide resolved
examples/with-sfcc/.gitignore Show resolved Hide resolved
examples/with-sfcc/README.md Outdated Show resolved Hide resolved
examples/with-sfcc/components/ProductCard.js Outdated Show resolved Hide resolved
examples/with-sfcc/package.json Outdated Show resolved Hide resolved
examples/with-sfcc/package.json Outdated Show resolved Hide resolved
examples/with-sfcc/package.json Outdated Show resolved Hide resolved
examples/with-sfcc/pages/_document.js Outdated Show resolved Hide resolved
examples/with-sfcc/prettier.config.js Outdated Show resolved Hide resolved
@manovotny
Copy link
Contributor

Excellent work @Nutlope and great suggestions @balazsorban44! 👏

Nutlope and others added 9 commits October 13, 2022 11:48
@Nutlope @balazsorban44
Update examples/with-sfcc/.gitignore
55d29f0 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@Nutlope @balazsorban44
Update examples/with-sfcc/.gitignore
c369f60 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@Nutlope @balazsorban44
Update examples/with-sfcc/components/ProductCard.js
61939a2 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@Nutlope @balazsorban44
Update examples/with-sfcc/package.json
75943a2 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@Nutlope @balazsorban44
Update examples/with-sfcc/package.json
d71e26f 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@Nutlope @balazsorban44
Update examples/with-sfcc/package.json
14ddbcb 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@Nutlope
addressed Balázs's feedback
147dffc
@Nutlope
Merge branch 'sfcc-example' of https://github.com/vercel/next.js into…
9bbfebe 
… sfcc-example
@Nutlope
Merge branch 'canary' into sfcc-example
44e2fbd
@Nutlope
Copy link
Contributor Author

Nutlope commented Oct 13, 2022

Thanks @manovotny! It was both of us :)

@Nutlope
Copy link
Contributor Author

Nutlope commented Oct 13, 2022 •
edited

@balazsorban44 Thanks for the detailed feedback! I went over the checklist and addressed all your comments.

I'd love to get this merged in for now and I can come back and convert to TypeScript after Next.js Conf as things are quite busy these next two weeks. cc @manovotny, lemme know if you agree with this thinking

@balazsorban44
Copy link
Member

balazsorban44 commented Oct 13, 2022 •
edited

Sure, we can follow up in a later PR 👍

@manovotny
Copy link
Contributor

@balazsorban44 Thanks for the detailed feedback! I went over the checklist and addressed all your comments.

I'd love to get this merged in for now and I can come back and convert to TypeScript after Next.js Conf as things are quite busy these next two weeks. cc @manovotny, lemme know if you agree with this thinking

I support this iterative approach and commit us to following up, as long as TS isn't a requirement for all examples.

@kodiakhq kodiakhq bot merged commit af739ed into canary Oct 13, 2022
@kodiakhq kodiakhq bot deleted the sfcc-example branch October 13, 2022 16:34
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
@Nutlope @ijjk @Kikobeats
Added example with salesforce commerce cloud (vercel#41376)
ee5a3c8 
Adding a Next.js example with Salesforce Commerce Cloud

Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@manovotny manovotny manovotny left review comments

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@steven-tey steven-tey Awaiting requested review from steven-tey

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Nutlope @manovotny @balazsorban44 @leerob @styfle @ijjk