Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: more detailed error message when failing to parse a middleware matcher #41390

Merged
merged 5 commits into from Oct 13, 2022

Conversation

feugy
Copy link
Member

@feugy feugy commented Oct 13, 2022

📖 What's in there?

This is a follow-up for #40180
Someone made the good point that users may get directed to this error page while setting up middleware matchers. And that page has no information (yet) about it.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

balazsorban44
balazsorban44 previously approved these changes Oct 13, 2022
@kodiakhq kodiakhq bot merged commit d8395e4 into vercel:canary Oct 13, 2022
@feugy
Copy link
Member Author

feugy commented Oct 14, 2022

Thank you @balazsorban44!

@feugy feugy deleted the docs/middleware-matcher-2 branch October 14, 2022 08:10
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
…matcher (vercel#41390)

## 📖 What's in there?

This is a follow-up for vercel#40180
Someone made the good point that users may get directed to this error page while setting up middleware matchers. And that page has no information (yet) about it.

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [x] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)



Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants