Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs for request headers overrides in middleware #41546

Merged
merged 3 commits into from Oct 19, 2022
Merged

Docs for request headers overrides in middleware #41546

merged 3 commits into from Oct 19, 2022

Conversation

nuta
Copy link
Contributor

@nuta nuta commented Oct 19, 2022

Docs for #41380

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@nuta nuta changed the title Support overriding request headers in middlewares Docs for request headers overrides in middleware Oct 19, 2022
S3Prototype
S3Prototype approved these changes Oct 19, 2022
View reviewed changes
Copy link
Contributor

@S3Prototype S3Prototype left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

S3Prototype
S3Prototype previously approved these changes Oct 19, 2022
View reviewed changes
@S3Prototype
Copy link
Contributor

@leerob @styfle @timneutkens Can we get a quick approval? Small change we need to merge before conf

balazsorban44
balazsorban44 requested changes Oct 19, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments

@balazsorban44 balazsorban44 merged commit 3f7e922 into vercel:canary Oct 19, 2022
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
@nuta @balazsorban44 @Kikobeats
Docs for request headers overrides in middleware (vercel#41546)
1987470 
Co-authored-by: Balázs Orbán <info@balazsorban.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@S3Prototype S3Prototype S3Prototype left review comments

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nuta @S3Prototype @balazsorban44 @ijjk