Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small change to note <Link /> executes server methods #41577

Merged
merged 7 commits into from Oct 20, 2022

Conversation

marcialca
Copy link
Contributor

I stumbled upon a lack of clarity when using <Link /> where I believed it didn't execute the server methods before navigation. This change makes it a bit more clear

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

I stumbled upon a lack of clarity when using `<Link />` where I believed it didn't execute the server methods before navigation. This change makes it a bit more clear
balazsorban44
balazsorban44 previously approved these changes Oct 19, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

styfle
styfle previously approved these changes Oct 19, 2022
docs/routing/introduction.md Outdated Show resolved Hide resolved
@ijjk ijjk dismissed stale reviews from styfle and balazsorban44 via 2b22725 October 20, 2022 00:40
@kodiakhq kodiakhq bot merged commit cec9d02 into vercel:canary Oct 20, 2022
@marcialca marcialca deleted the patch-1 branch October 20, 2022 14:44
Kikobeats pushed a commit to Kikobeats/next.js that referenced this pull request Oct 24, 2022
I stumbled upon a lack of clarity when using `<Link />` where I believed it didn't execute the server methods before navigation. This change makes it a bit more clear

## Documentation / Examples

- [ ] Make sure the linting passes by running `pnpm lint`
- [ ] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)


Co-authored-by: Balázs Orbán <18369201+balazsorban44@users.noreply.github.com>
Co-authored-by: JJ Kasper <22380829+ijjk@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants