Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Four Broken Links in next/image Documentation Examples #41578

Closed
kr1st1nagr03g3r opened this issue Oct 19, 2022 · 2 comments
Closed

Docs: Four Broken Links in next/image Documentation Examples #41578

kr1st1nagr03g3r opened this issue Oct 19, 2022 · 2 comments
Labels
Documentation Related to Next.js' official documentation.

Comments

@kr1st1nagr03g3r
Copy link

What is the improvement or update you wish to see?

Steps to reproduce issue:

Please note that I do see a recent commit here, however it didn't fix this particular issue.

  1. Navigate to the next/image optional props doc
  2. Click on the following links:
    Demo the intrinsic layout (default)
    Demo the fixed layout
    Demo the responsive layout
    Demo the fill layout
  3. On each of the four links mentioned above, clicking on the Github icon at the top right results in a 404 error.
    On:
    Demo the intrinsic layout (default) Github links to: layout-intrinsic.jsx
    Demo the fixed layout Github links to: layout-fixed.tsx
    Demo the responsive layout Github links to: layout-responsive.tsx
    Demo the fill layout Github links to: layout-fill.tsx

Thanks!

Is there any context that might help us understand?

  1. Demo the intrinsic layout (default) Github link should go to a layout-intrinsic.tsx file, however I do not see it in this repo. I'm aware that intrinsic is the default, but a broken link still remains.
  2. Demo the fixed layout Github link should go to a layout-fixed.jsx file, however I do not see it in this repo
  3. Demo the responsive layout Github link should go to: responsive.tsx
  4. Demo the fill layout Github link should go to: fill.tsx

Does the docs page already exist? Please link to it.

https://image-component.nextjs.gallery/

@kr1st1nagr03g3r kr1st1nagr03g3r added the Documentation Related to Next.js' official documentation. label Oct 19, 2022
@balazsorban44
Copy link
Member

Thanks, the documentation updates you mentioned have been merged, and will be reflected on the website the next time a new latest version of next is released, which is soon, so keep an eye on it. 🙏

@github-actions
Copy link
Contributor

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Documentation Related to Next.js' official documentation.
Projects
None yet
Development

No branches or pull requests

2 participants