Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static generation and crawler requests #41735

Merged
merged 5 commits into from Oct 24, 2022
Merged

Fix static generation and crawler requests #41735

merged 5 commits into from Oct 24, 2022

Conversation

shuding
Copy link
Member

@shuding shuding commented Oct 24, 2022

Right now the SSG condition is determined only based on supportsDynamicHTML. However that supportsDynamicHTML flag can be affected by bots too.

Here we exclude the isBot condition from the SSG flag, and set proper status and meta tags for static HTML requests (and/or 404 cases).

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

ijjk
ijjk previously approved these changes Oct 24, 2022
@ijjk
Copy link
Member

ijjk commented Oct 24, 2022

Failing test suites

Commit: 6067bd6

pnpm testheadless test/development/acceptance-app/ReactRefreshLogBox.test.ts

  • ReactRefreshLogBox app > logbox: can recover from a syntax error without losing state
Expand output

● ReactRefreshLogBox app › logbox: can recover from a syntax error without losing state

TIMED OUT: /Count: 1/

Count: 0

  519 |
  520 |   if (hardError) {
> 521 |     throw new Error('TIMED OUT: ' + regex + '\n\n' + content)
      |           ^
  522 |   }
  523 |   return false
  524 | }

  at check (lib/next-test-utils.js:521:11)
  at Object.<anonymous> (development/acceptance-app/ReactRefreshLogBox.test.ts:107:5)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk merged commit 383ec5a into canary Oct 24, 2022
@ijjk ijjk deleted the shu/1nhx branch October 24, 2022 20:38
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants