Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update with-aws-amplify with TypeScript #41815

Merged
merged 6 commits into from Oct 26, 2022
Merged

Update with-aws-amplify with TypeScript #41815

merged 6 commits into from Oct 26, 2022

Conversation

christianipanaque
Copy link
Contributor

@christianipanaque christianipanaque commented Oct 26, 2022

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc
  • Updated aws-amplify and @aws-amplify/ui-react to latest versions
  • Updated README.md with latest command line prompts from amplify and @aws-amplify/cli
  • Added latest versions of typescript, @types/react, @types/react-dom, and @types/node
  • Deleted all files in with-aws-amplify-typescript and updated README.md to indicate that it has moved to with-aws-amplify

Previous work:

@ijjk ijjk added the examples Issue/PR related to examples label Oct 26, 2022
@christianipanaque christianipanaque marked this pull request as ready for review October 26, 2022 02:29
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 97422c6 into vercel:canary Oct 26, 2022
@christianipanaque christianipanaque deleted the chrisipanaque/update-with-aws-amplify-fix-35222 branch October 27, 2022 23:17
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

with-aws-amplify-typescript uses legacy AmplifyAuthenticator
4 participants