Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert many examples to TypeScript #41825

Merged
merged 23 commits into from Oct 26, 2022

Conversation

maxproske
Copy link
Contributor

Strategized with @balazsorban44 to open one larger PR, with changes to individual examples as separate commits.

For each example, I researched how multiple realworld codebases use the featured technology with TypeScript, to thoughtfully convert them by hand - nothing automated whatsoever.

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Oct 26, 2022
balazsorban44
balazsorban44 previously approved these changes Oct 26, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Impressive work, thanks!

@balazsorban44 balazsorban44 self-requested a review October 26, 2022 18:05
@balazsorban44 balazsorban44 dismissed their stale review October 26, 2022 18:09

Hold, extra feedback

@kodiakhq kodiakhq bot merged commit 5dd4999 into vercel:canary Oct 26, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants