Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove swcMinify: true as it's the new default. #41877

Merged
merged 3 commits into from Oct 26, 2022
Merged

chore: remove swcMinify: true as it's the new default. #41877

merged 3 commits into from Oct 26, 2022

Conversation

balazsorban44
Copy link
Member

Follow-up on #41869

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue/PR related to examples labels Oct 26, 2022
@balazsorban44 balazsorban44 merged commit fb8febd into canary Oct 26, 2022
@balazsorban44 balazsorban44 deleted the chore/remove-swcminify-default-config branch October 26, 2022 17:55
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application. examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@balazsorban44 @styfle @ijjk