Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed errors at with-passport-and-next-connect. #41897

Merged
merged 3 commits into from Oct 26, 2022
Merged

Fixed errors at with-passport-and-next-connect. #41897

merged 3 commits into from Oct 26, 2022

Conversation

balazsorban44
Copy link
Member

Lands #41854 with lint fixes. Closes #41854

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Oct 26, 2022
@balazsorban44 balazsorban44 changed the title Fixed Errors Fixed errors at with-passport-and-next-connect. Oct 26, 2022
@balazsorban44 balazsorban44 merged commit 11d9925 into canary Oct 26, 2022
@balazsorban44 balazsorban44 deleted the wilken311/canary branch October 26, 2022 20:34
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@balazsorban44 @styfle @ijjk @wilken311