Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update example dev script #41904

Merged
merged 4 commits into from Oct 27, 2022
Merged

chore: update example dev script #41904

merged 4 commits into from Oct 27, 2022

Conversation

Kosai106
Copy link
Contributor

@Kosai106 Kosai106 commented Oct 26, 2022

The README and install step already indicates that this example is using Turbopack, which doesn't fully support Tailwind so why not preconfigure the correct dev script from the start?

(I've left the following checkboxes clear as I do not believe they apply here.)

Documentation / Examples

  • Make sure the linting passes by running pnpm lint
  • The "examples guidelines" are followed from our contributing doc

The README and install step already indicates that this example is using Turbopack, which doesn't fully support Tailwind so why not preconfigure the correct dev script from the start?
@ijjk ijjk added the examples Issue/PR related to examples label Oct 26, 2022
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kodiakhq kodiakhq bot merged commit 8035770 into vercel:canary Oct 27, 2022
@Kosai106 Kosai106 deleted the patch-1 branch October 27, 2022 12:21
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants