Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Examples to use React 18 #42027

Merged
merged 3 commits into from Oct 28, 2022
Merged

Update Examples to use React 18 #42027

merged 3 commits into from Oct 28, 2022

Conversation

craigwheeler
Copy link
Contributor

@craigwheeler craigwheeler commented Oct 28, 2022 •
edited by balazsorban44

This PR updates the minimum version of React used by examples from 17.0.2 to 18.2.0.

Fixes #41975

Bug

  • Related issues linked using fixes #41975
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Oct 28, 2022
@craigwheeler craigwheeler mentioned this pull request Oct 28, 2022
Closed
1 task
@kodiakhq kodiakhq bot merged commit 57426a2 into vercel:canary Oct 28, 2022
@balazsorban44 balazsorban44 mentioned this pull request Oct 28, 2022
Closed
1 task
@craigwheeler craigwheeler deleted the update-react-version branch October 28, 2022 21:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error: Next.js requires React 18.2.0 to be installed.
4 participants
@craigwheeler @balazsorban44 @styfle @ijjk