Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update font-optimization.md #42036

Merged
merged 1 commit into from Oct 28, 2022
Merged

Conversation

peraltafederico
Copy link
Contributor

@peraltafederico peraltafederico commented Oct 28, 2022

This PR fixes the documentation of @next/font/local. In the current documentation, className is called from localFont which comes from @next/font/local instead of doing it from the result of calling localFont itself.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

This PR fix the documentation of `@next/font/local`. In the current documentation, `className` is called from `localFont` which comes from `@next/font/local` instead of doing it from the result of calling `localFont` itself.
@balazsorban44 balazsorban44 merged commit d07ae34 into vercel:canary Oct 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants