Convert custom-server-express example to TypeScript
#42110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxproske
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
|
Thanks for the link! Though I think this example should be maintained as long as it's referenced by the Next.js custom server docs. |
|
@leerob What do you think we should do with the following JavaScript examples? I think they should be maintained and converted to TypeScript, however based on your comment #33128 (comment), it sounds like custom servers aren't recommended, and therefore the examples can't be updated. If this is the case, it might make sense to deprecate them in favour of the main
|
|
I think we can remove them in favor of the custom server example 👍 |
2 tasks
kodiakhq bot
pushed a commit
that referenced
this pull request
Nov 7, 2022
Fixes @leerob's comment #42110 (comment) ~~Deprecated~~ Removed all custom server integration examples (Express, Fastify, etc.) in favour of the main `custom-server` example, ~~and left behind a helpful `README.md` in case they might be linked to.~~ ## Documentation / Examples - [X] Make sure the linting passes by running `pnpm build && pnpm lint` - [X] The "examples guidelines" are followed from [our contributing doc](https://github.com/vercel/next.js/blob/canary/contributing/examples/adding-examples.md)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted Express example to TypeScript to match Contribution docs.
nodemonto match thecustom-serverexample, and allow live reloading ofserver.ts<Link href="/a" as="/b">routingDocumentation / Examples
pnpm build && pnpm lint