Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correcting documentation #42179

Merged
merged 2 commits into from Oct 30, 2022
Merged

Correcting documentation #42179

merged 2 commits into from Oct 30, 2022

Conversation

artdevgame
Copy link
Contributor

response hasn't been defined in the documentation at the point that a cookie check is being made. The update makes the check against the request object instead.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • [] Make sure the linting passes by running pnpm build && pnpm lint
  • [] The "examples guidelines" are followed from our contributing doc

`response` hasn't been defined in the documentation at the point that a cookie check is being made. The update makes the check against the `request` object instead.
@kodiakhq kodiakhq bot merged commit 8ada894 into vercel:canary Oct 30, 2022
@artdevgame artdevgame deleted the patch-1 branch October 30, 2022 19:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants