Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update response-helpers.md #42378

Merged
merged 6 commits into from Nov 4, 2022
Merged

Update response-helpers.md #42378

merged 6 commits into from Nov 4, 2022

Conversation

ws-jm
Copy link
Contributor

@ws-jm ws-jm commented Nov 2, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

ijjk
ijjk previously approved these changes Nov 3, 2022
Co-authored-by: Steven <steven@ceriously.com>
balazsorban44
balazsorban44 previously approved these changes Nov 4, 2022
@kodiakhq kodiakhq bot merged commit 4ffde56 into canary Nov 4, 2022
@kodiakhq kodiakhq bot deleted the docs/ts-nextapirequest branch November 4, 2022 05:37
@@ -98,6 +98,8 @@ export default function handler(
}
```

> Note: The body of `NextApiRequest` is `any` because the client may include any payload. You should validate the type/shape of the body at runtime before using it.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't really tell me what to do though. Should there be an example?

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants