Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include app directory in Tailwind config #42407

Merged
merged 2 commits into from Nov 4, 2022
Merged

Include app directory in Tailwind config #42407

merged 2 commits into from Nov 4, 2022

Conversation

phantaaa
Copy link
Contributor

@phantaaa phantaaa commented Nov 3, 2022

Updated with-tailwindcss example to include new app directory according to Tailwind docs

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Nov 3, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This example currently does not have an app/ directory or is not even enabled via next.config.js. I wonder if this change makes sense as of now.

@phantaaa
Copy link
Contributor Author

phantaaa commented Nov 4, 2022

For people that want to make use of Next.js 13 app directory yes, it took me a while at first to figure out why my Tailwind doesn't work when adapting to new changes. Official Tailwind docs already added it so doesn't hurt to add it here as well.

@kodiakhq kodiakhq bot merged commit ee7c5aa into vercel:canary Nov 4, 2022
@phantaaa phantaaa deleted the tailwind-app-dir branch November 5, 2022 06:18
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants