Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert with-absolute-imports example to TypeScript #42529

Merged
merged 5 commits into from Nov 7, 2022

Conversation

maxproske
Copy link
Contributor

@maxproske maxproske commented Nov 6, 2022

Converted example to TypeScript to match Contribution docs.

  • Renamed with-absolute-imports example to absolute-imports-and-aliases to match Contribution docs
  • Replaced deprecated example with a README.md file
  • Used module path aliases in example, to help developers decide which import strategy to use

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, but I don't think we need to rename existing examples just for the sake of it, as it introduces unnecessary changes. We should not just remove examples as there might be links to them from other places.

@maxproske
Copy link
Contributor Author

@balazsorban44 Done. That makes sense, I'll keep existing examples prefixed with with- as is.

@maxproske maxproske changed the title Improve absolute-imports-and-aliases example and convert to TypeScript Convert with-absolute-imports example to TypeScript Nov 7, 2022
@ijjk ijjk merged commit 6f136f6 into vercel:canary Nov 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants