Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove all custom server integration examples #42549

Merged

Conversation

maxproske
Copy link
Contributor

@maxproske maxproske commented Nov 6, 2022

Fixes @leerob's comment #42110 (comment)

Deprecated Removed all custom server integration examples (Express, Fastify, etc.) in favour of the main custom-server example, and left behind a helpful README.md in case they might be linked to.

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@leerob
Copy link
Member

leerob commented Nov 6, 2022

I think we can go ahead and remove the folder entirely 👍

@maxproske maxproske changed the title Deprecate all custom server integration examples Remove all custom server integration examples Nov 6, 2022
@maxproske
Copy link
Contributor Author

Done! Thanks @leerob for your outwordly-fast feedback.

Copy link
Member

@leerob leerob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP in peace

@kodiakhq kodiakhq bot merged commit 984627a into vercel:canary Nov 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants