Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test retry cleanup #43011

Merged
merged 1 commit into from Nov 16, 2022
Merged

Fix test retry cleanup #43011

merged 1 commit into from Nov 16, 2022

Conversation

ijjk
Copy link
Member

@ijjk ijjk commented Nov 16, 2022

As noticed in #42966 (review) we weren't resetting tests correctly on retry causing an incorrect pass.

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Nov 16, 2022
@ijjk
Copy link
Member Author

ijjk commented Nov 16, 2022

Failing test suites

Commit: 3a67580

pnpm testheadless test/integration/dynamic-routing/test/middleware.test.js

  • Dynamic Routing > dev mode > should render dynamic route with query
Expand output

● Dynamic Routing › dev mode › should render dynamic route with query

expect(received).toBe(expected) // Object.is equality

Expected: "?fromHome=true"
Received: ""

  428 |     await waitFor(1000)
  429 |     const url = await browser.eval('window.location.search')
> 430 |     expect(url).toBe('?fromHome=true')
      |                 ^
  431 |   })
  432 |
  433 |   if (dev) {

  at Object.<anonymous> (integration/dynamic-routing/test/index.test.js:430:17)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk marked this pull request as ready for review November 16, 2022 20:22
@ijjk ijjk merged commit 295f15e into vercel:canary Nov 16, 2022
@ijjk ijjk deleted the fix/test-retry-cleanup branch November 16, 2022 21:16
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant