Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert with-cssed, with-csx, with-styled-jsx examples to TypeScript #43018

Merged
merged 3 commits into from Nov 17, 2022
Merged

Convert with-cssed, with-csx, with-styled-jsx examples to TypeScript #43018

merged 3 commits into from Nov 17, 2022

Conversation

maxproske
Copy link
Contributor

@maxproske maxproske commented Nov 17, 2022 •
edited

Updated 3 more examples to TypeScript. Changes to individual examples pushed as separate commits.

  • Swapped cxs/lite for cxs, as it's the only mode supported by @types/cxs.

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Nov 17, 2022
@ijjk ijjk merged commit 07d3da1 into vercel:canary Nov 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxproske @ijjk