chore(examples): with-msw update msw #43224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using msw `0.47.3` doesn't work in this example. Updating msw to `^0.49.0` and not locking it to an exact version.
andykenward
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
4 tasks
balazsorban44
approved these changes
Nov 22, 2022
balazsorban44
changed the title
|
Thanks for fixing this, @andykenward 👏 |
jankaifer
pushed a commit
to jankaifer/next.js
that referenced
this pull request
Nov 23, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLOSES #43221
Using msw
0.47.3doesn't work in this example. Updating msw to^0.49.0and not locking it to an exact version.Screenshots of errors using
0.47.3Documentation / Examples
pnpm build && pnpm lint