Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix With Passport example #43232

Merged
merged 1 commit into from Nov 22, 2022
Merged

Fix With Passport example #43232

merged 1 commit into from Nov 22, 2022

Conversation

Yutsuten
Copy link
Contributor

@Yutsuten Yutsuten commented Nov 22, 2022

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • Integration tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint

I tried to run pnpm build && pnpm lint but I'm not being able to setup my environment. pnpm install always finish with ELIFECYCLE  Command failed. I'm just fixing a single example, could someone with their environment setup try this for me, please?
I have no plans in actively contribute to Next.js, I don't want to spend even more time to setup something I won't use...


When npm install the examples/with-passport, an error would appear.

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: undefined@undefined
npm ERR! Found: react@18.2.0
npm ERR! node_modules/react
npm ERR!   react@"^18.2.0" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react@"^16.11.0 || ^17.0.0" from swr@0.5.7
npm ERR! node_modules/swr
npm ERR!   swr@"^0.5.5" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See /home/user/.npm/eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/user/.npm/_logs/2022-11-22T09_55_34_203Z-debug-0.log

This PR fixes it.

@ijjk ijjk added the examples Issue/PR related to examples label Nov 22, 2022
@balazsorban44 balazsorban44 merged commit 3a2af8f into vercel:canary Nov 22, 2022
@Yutsuten Yutsuten deleted the fix-with-passport-example branch November 22, 2022 13:09
jankaifer pushed a commit to jankaifer/next.js that referenced this pull request Nov 23, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants