Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Add notes about NEXT_MANUAL_SIG_HANDLE #43686

Merged
merged 2 commits into from Dec 4, 2022
Merged

docs: Add notes about NEXT_MANUAL_SIG_HANDLE #43686

merged 2 commits into from Dec 4, 2022

Conversation

soonoo
Copy link
Contributor

@soonoo soonoo commented Dec 4, 2022

It seems that setting NEXT_MANUAL_SIG_HANDLE in .env file is not working, so I added some notes.

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

ijjk
ijjk approved these changes Dec 4, 2022
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to document this limitation as this env variable needs to be set on proces start which is before the env files are loaded, thanks!

@kodiakhq kodiakhq bot merged commit 0bd3422 into vercel:canary Dec 4, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@shuding shuding Awaiting requested review from shuding

@styfle styfle Awaiting requested review from styfle

@huozhi huozhi Awaiting requested review from huozhi

@padmaia padmaia Awaiting requested review from padmaia

@leerob leerob Awaiting requested review from leerob

@balazsorban44 balazsorban44 Awaiting requested review from balazsorban44

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@soonoo @ijjk