Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert with-why-did-you-render example to TypeScript #43736

Merged
merged 1 commit into from Dec 7, 2022
Merged

Convert with-why-did-you-render example to TypeScript #43736

merged 1 commit into from Dec 7, 2022

Conversation

maxproske
Copy link
Contributor

@maxproske maxproske commented Dec 5, 2022 •
edited

Converted example to TypeScript to match Contribution docs.

x-ref: welldone-software/why-did-you-render#161 (comment)

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

@ijjk ijjk added the examples Issue/PR related to examples label Dec 5, 2022
@balazsorban44 balazsorban44 merged commit f56e5c9 into vercel:canary Dec 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxproske @balazsorban44 @ijjk