Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): Update convex example #43741

Merged
merged 2 commits into from Dec 7, 2022

Conversation

thomasballinger
Copy link
Contributor

This example is now very similar to the one at https://github.com/get-convex/convex-demos/tree/main/typescript which should make it easier to keep it updated moving forward.

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

This example is now very similar to the one at https://github.com/get-convex/convex-demos/tree/main/typescript
which should make it easier to keep in updated moving forward.
@ijjk ijjk added the examples Issue/PR related to examples label Dec 5, 2022
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, maybe it would make sense to deprecate this example and have a single README.md that points to the official example to avoid maintenance duplicate work. 🤔

@balazsorban44 balazsorban44 changed the title Update convex example chore(examples): Update convex example Dec 7, 2022
@balazsorban44 balazsorban44 merged commit dbc8334 into vercel:canary Dec 7, 2022
@thomasballinger
Copy link
Contributor Author

Thanks for merging @balazsorban44.

I really like using create-next-app to start new Convex projects and we hear the same from customers so we'd love to keep this in. If you're willing to keep merging updates, we'll keep them coming 😄

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants