Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

corrected /examples/github-pages readme #43766

Merged
merged 3 commits into from Dec 12, 2022
Merged

corrected /examples/github-pages readme #43766

merged 3 commits into from Dec 12, 2022

Conversation

ghost
Copy link

@ghost ghost commented Dec 6, 2022

branch is the correct subheading direction; the source subheading represents deploying from a branch or from a github action

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

`branch` is the correct subheading direction; the `source` subheading represents `deploying from a branch` or from a `github action`
@ijjk ijjk added the examples Issue/PR related to examples label Dec 6, 2022
@kodiakhq kodiakhq bot merged commit af0ac94 into vercel:canary Dec 12, 2022
@ghost ghost deleted the labyrinthitis-patch-1 branch December 13, 2022 18:14
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant