Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for rendering null and undefined in RSC #43768

Merged
merged 6 commits into from Dec 7, 2022
Merged

Add tests for rendering null and undefined in RSC #43768

merged 6 commits into from Dec 7, 2022

Conversation

jankaifer
Copy link
Contributor

@jankaifer jankaifer commented Dec 6, 2022 •
edited

Add tests for returning null and undefined from page.js, layout.js and components in app directory.

@jankaifer jankaifer marked this pull request as ready for review December 6, 2022 14:04
timneutkens
timneutkens approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 Great work!

@timneutkens timneutkens closed this Dec 7, 2022
@timneutkens timneutkens reopened this Dec 7, 2022
@timneutkens timneutkens merged commit 08d270c into vercel:canary Dec 7, 2022
@jankaifer jankaifer deleted the jankaifer/nex-120-add-test-returning-null-from-a-server branch December 8, 2022 15:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@timneutkens timneutkens timneutkens approved these changes

@ijjk ijjk Awaiting requested review from ijjk ijjk is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@huozhi huozhi Awaiting requested review from huozhi huozhi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jankaifer @timneutkens