Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove swcMinify from Next config in CNA template #43782

Merged
merged 4 commits into from Dec 7, 2022
Merged

Remove swcMinify from Next config in CNA template #43782

merged 4 commits into from Dec 7, 2022

Conversation

iteratetograceness
Copy link
Contributor

Since swcMinify is now added by default, there is no need to explicitly include it in next.config.js.

@ijjk ijjk added the create-next-app Related to our CLI tool for quickly starting a new Next.js application. label Dec 6, 2022
balazsorban44
balazsorban44 requested changes Dec 6, 2022
View reviewed changes
Copy link
Member

@balazsorban44 balazsorban44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we revert the pnpm-lock.yaml file change? Seems to be unnecessary for this PR

@balazsorban44 balazsorban44 merged commit 783a3ce into vercel:canary Dec 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balazsorban44 balazsorban44 balazsorban44 approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens

@ijjk ijjk Awaiting requested review from ijjk

@shuding shuding Awaiting requested review from shuding

@huozhi huozhi Awaiting requested review from huozhi

Assignees
No one assigned
Labels
create-next-app Related to our CLI tool for quickly starting a new Next.js application.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@iteratetograceness @balazsorban44 @ijjk