Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove notifications emitted during pnpm dev #43801

Merged
merged 8 commits into from
Dec 7, 2022

Conversation

jankaifer
Copy link
Contributor

@jankaifer jankaifer commented Dec 7, 2022

Disable notifications when running pnpm dev It's broken M1 and not useful on Gnome.

Unverified

This user has not yet uploaded their public signing key.
@jankaifer jankaifer force-pushed the remove-dev-notifications branch from dc05f18 to 1309eb0 Compare December 7, 2022 10:11
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a review

@jankaifer jankaifer requested a review from timneutkens December 7, 2022 10:50
timneutkens
timneutkens previously approved these changes Dec 7, 2022
Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :thumbs:

Copy link
Member

@timneutkens timneutkens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to land now. Weird issue with the lockfile getting a lot of changes.

@timneutkens timneutkens merged commit aa7cdf3 into vercel:canary Dec 7, 2022
@jankaifer jankaifer deleted the remove-dev-notifications branch December 8, 2022 15:59
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants