Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler.md #43872

Merged
merged 4 commits into from Dec 10, 2022
Merged

Update compiler.md #43872

merged 4 commits into from Dec 10, 2022

Conversation

aziyatali
Copy link
Contributor

@aziyatali aziyatali commented Dec 9, 2022

The sentence is very confusing. Excessive/invalid usage of English grammar

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

The sentence is very confusing. Excessive/invalid usage of English grammar
includes makes more sense than support
@kodiakhq kodiakhq bot merged commit 6c1dd22 into vercel:canary Dec 10, 2022
@aziyatali
Copy link
Contributor Author

@styfle Steven, transpiles(aka: transpiler) sounds hard for beginner programmers. Would be better if we could find some alternative!

@styfle
Copy link
Member

styfle commented Dec 10, 2022

What do you suggest?

@aziyatali
Copy link
Contributor Author

@styfle Let's leave as it is. If they won't understand then they will search for it. At worst case they will learn new concept `source-to-source' compiler!

@aziyatali aziyatali deleted the patch-1 branch December 11, 2022 04:39
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants