Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary babel.config.js in react native web example #43939

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

nissy-dev
Copy link
Contributor

@nissy-dev nissy-dev commented Dec 11, 2022

Documentation / Examples

Based on necolas/react-native-web#2217, the babel-plugin-react-native-web is not necessary. Therefore, I remove babel.config.js and npm package from package.json. This modification will improve build performance and bundle size.

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

Sorry, something went wrong.

@ijjk ijjk added the examples Issue was opened via the examples template. label Dec 11, 2022
@nissy-dev nissy-dev changed the title chore(examples): remove unnecessary babel settings in react native web example remove unnecessary babel settings in react native web example Dec 30, 2022
@nissy-dev nissy-dev changed the title remove unnecessary babel settings in react native web example remove unnecessary babel.config.js in react native web example Dec 30, 2022
@nissy-dev
Copy link
Contributor Author

@ijjk I would like to review this PR 🙇 I'm a creator of swc-plugin-react-native-web, but I'm in trouble because many users uses it referencing this example settings and reports an error to my repo.

In many cases, users doesn't need to use babel plugin and swc plugin.

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to remove this as it shouldn't be recommended by default, thanks!

Verified

This commit was signed with the committer’s verified signature.
ijjk JJ Kasper
@ijjk ijjk merged commit 6da0444 into vercel:canary Jan 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue was opened via the examples template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants