Create i18n example using app-dir and middleware #44257
Merged
+312
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jankaifer
requested review from
timneutkens,
ijjk,
shuding,
leerob,
steven-tey and
balazsorban44
as code owners
ijjk
added
examples
jankaifer
commented
Dec 22, 2022
jankaifer
commented
Dec 22, 2022
joulev
reviewed
Dec 26, 2022
Co-authored-by: Vu Van Dung <joulev.vvd@yahoo.com>
Co-authored-by: Vu Van Dung <joulev.vvd@yahoo.com>
timneutkens
approved these changes
Jan 5, 2023
jankaifer
deleted the
jankaifer/next-226-create-definitive-i18n-example-for-app
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a new example using
middlewareandapp-dir.There is a preview here: https://app-dir-i18n-routing-9ej40rbhx-jankaifer.vercel.app/
The middleware seems to be running on the edge and there are no issues with
negotiator.