Skip to content

Improve errors caused by client hook called in a server component #44538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

hanneslund
Copy link
Contributor

Improve errors caused by client hook called in a server component.

Before
image

After
image

Fixes NEXT-311

Bug

  • Related issues linked using fixes #number
  • Integration tests added
  • Errors have a helpful link attached, see contributing.md

Feature

  • Implements an existing feature request or RFC. Make sure the feature request has been accepted for implementation before opening a PR.
  • Related issues linked using fixes #number
  • e2e tests added
  • Documentation added
  • Telemetry added. In case of a feature if it's used or not.
  • Errors have a helpful link attached, see contributing.md

Documentation / Examples

  • Make sure the linting passes by running pnpm build && pnpm lint
  • The "examples guidelines" are followed from our contributing doc

Sorry, something went wrong.

Hannes Bornö added 4 commits January 3, 2023 17:24

Verified

This commit was signed with the committer’s verified signature.
ijjk JJ Kasper

Verified

This commit was signed with the committer’s verified signature.
ijjk JJ Kasper
@ijjk
Copy link
Member

ijjk commented Jan 3, 2023

Stats from current PR

Default Build (Decrease detected ✓)
General Overall increase ⚠️
vercel/next.js canary hanneslund/next.js client-hook-in-server-improved-error Change
buildDuration 43.2s 41.9s -1.3s
buildDurationCached 18.2s 12.6s -5.6s
nodeModulesSize 95.2 MB 95.2 MB
nextStartRea..uration (ms) 317ms 330ms ⚠️ +13ms
Client Bundles (main, webpack)
vercel/next.js canary hanneslund/next.js client-hook-in-server-improved-error Change
152-HASH.js gzip 64.5 kB 64.5 kB
53.HASH.js gzip 182 B 182 B
main-app-HASH.js gzip 205 B 205 B
main-HASH.js gzip 79.2 kB 79.2 kB
webpack-HASH.js gzip 1.7 kB 1.7 kB
Overall change 146 kB 146 kB
Legacy Client Bundles (polyfills)
vercel/next.js canary hanneslund/next.js client-hook-in-server-improved-error Change
polyfills-HASH.js gzip 31 kB 31 kB
Overall change 31 kB 31 kB
Client Pages
vercel/next.js canary hanneslund/next.js client-hook-in-server-improved-error Change
_app-HASH.js gzip 192 B 192 B
_error-HASH.js gzip 179 B 179 B
amp-HASH.js gzip 484 B 484 B
css-HASH.js gzip 804 B 804 B
dynamic-HASH.js gzip 2.27 kB 2.27 kB
edge-ssr-HASH.js gzip 255 B 255 B
head-HASH.js gzip 827 B 827 B
hooks-HASH.js gzip 848 B 848 B
image-HASH.js gzip 4.3 kB 4.3 kB
index-HASH.js gzip 252 B 252 B
link-HASH.js gzip 2.69 kB 2.69 kB
routerDirect..HASH.js gzip 782 B 782 B
script-HASH.js gzip 857 B 857 B
withRouter-HASH.js gzip 781 B 781 B
85e02e95b279..7e3.css gzip 107 B 107 B
Overall change 15.6 kB 15.6 kB
Client Build Manifests
vercel/next.js canary hanneslund/next.js client-hook-in-server-improved-error Change
_buildManifest.js gzip 482 B 482 B
Overall change 482 B 482 B
Rendered Page Sizes
vercel/next.js canary hanneslund/next.js client-hook-in-server-improved-error Change
index.html gzip 490 B 490 B
link.html gzip 506 B 506 B
withRouter.html gzip 485 B 485 B
Overall change 1.48 kB 1.48 kB
Edge SSR bundle Size Overall decrease ✓
vercel/next.js canary hanneslund/next.js client-hook-in-server-improved-error Change
edge-ssr.js gzip 110 kB 110 kB
page.js gzip 98.4 kB 98.4 kB -1 B
Overall change 209 kB 209 kB -1 B
Middleware size
vercel/next.js canary hanneslund/next.js client-hook-in-server-improved-error Change
middleware-b..fest.js gzip 585 B 585 B
middleware-r..fest.js gzip 145 B 145 B
middleware.js gzip 27.1 kB 27.1 kB
edge-runtime..pack.js gzip 1.83 kB 1.83 kB
Overall change 29.7 kB 29.7 kB
Commit: 73a9dae

@hanneslund hanneslund marked this pull request as ready for review January 4, 2023 09:21
@kodiakhq kodiakhq bot merged commit d89bdb2 into vercel:canary Jan 4, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants