Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flakey polyfills and acceptance tests #45313

Merged
merged 1 commit into from Jan 26, 2023

Conversation

@ijjk ijjk added the created-by: Next.js team PRs by the Next.js team label Jan 26, 2023
@ijjk
Copy link
Member Author

ijjk commented Jan 26, 2023

Failing test suites

Commit: 324ced6

pnpm testheadless test/integration/production/test/index.test.js

  • Production Usage > With navigation > should set title by routeChangeComplete event
Expand output

● Production Usage › With navigation › should set title by routeChangeComplete event

expect(received).toBe(expected) // Object.is equality

Expected: "hello from title"
Received: ""

  794 |       const title = await browser.eval(`window.routeChangeTitle`)
  795 |       const url = await browser.eval(`window.routeChangeUrl`)
> 796 |       expect(title).toBe('hello from title')
      |                     ^
  797 |       expect(url).toBe('/with-title')
  798 |     })
  799 |

  at Object.<anonymous> (integration/production/test/index.test.js:796:21)

Read more about building and testing Next.js in contributing.md.

pnpm testheadless test/e2e/fetch-failures-have-good-stack-traces-in-edge-runtime/fetch-failures-have-good-stack-traces-in-edge-runtime.test.ts

  • fetch failures have good stack traces in edge runtime > when returning fetch using an unknown domain, stack traces are preserved
Expand output

● fetch failures have good stack traces in edge runtime › when returning fetch using an unknown domain, stack traces are preserved

expect(received).toMatch(expected)

Expected pattern: /at.+\/pages\/api\/unknown-domain-no-await.js/
Received string:  "yarn run v1.22.19
$ /tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/node_modules/.bin/next build
info  - Linting and checking validity of types...
info  - Creating an optimized production build...
info  - Using locally built binary of @next/swc
info  - Compiled successfully
info  - Collecting page data...
info  - Generating static pages (0/3)
info  - Generating static pages (3/3)
info  - Finalizing page optimization...·
Route (pages)                              Size     First Load JS
┌ ○ /                                      260 B          73.2 kB
├ ○ /404                                   182 B          73.1 kB
├ ℇ /api/unknown-domain                    0 B              73 kB
└ ℇ /api/unknown-domain-no-await           0 B              73 kB
+ First Load JS shared by all              73 kB
  ├ chunks/framework-93f3b2d2d07baa50.js   45.2 kB
  ├ chunks/main-107b967b4c9eef5e.js        26.8 kB
  ├ chunks/pages/_app-eaab9bdae5cdd8c7.js  195 B
  └ chunks/webpack-4e7214a60fad8e88.js     712 B·
ℇ  (Streaming)  server-side renders with streaming (uses React 18 SSR streaming or Server Components)
○  (Static)     automatically rendered as static HTML (uses no initial props)·
Done in 24.20s.
yarn run v1.22.19
$ /tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/node_modules/.bin/next start
ready - started server on 0.0.0.0:34379, url: http://localhost:34379
Error [TypeError]: fetch failed

  at context.fetch (../file:/tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/node_modules/.pnpm/file+..+..+work+packages+next+packed-next.tgz_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/server/web/sandbox/context.js:167:38)
  at n (../file:/tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/.next/server/pages/api/unknown-domain.js:1:480)
  at s (../file:/tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/.next/server/pages/api/unknown-domain.js:1:436)
  at Object.o [as handler] (../file:/tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/.next/server/pages/api/unknown-domain.js:1:583)
  at ee (../file:/tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/.next/server/pages/api/unknown-domain.js:12:13813)
  at o (../file:/tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/.next/server/pages/api/unknown-domain.js:1:325)
  at <unknown> (../file:/tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/node_modules/.pnpm/file+..+..+work+packages+next+packed-next.tgz_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/server/web/sandbox/sandbox.js:73:30)
  at async NextNodeServer.runEdgeFunction (../file:/tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/node_modules/.pnpm/file+..+..+work+packages+next+packed-next.tgz_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/server/next-server.js:1413:24)
  at async NextNodeServer.runApi (../file:/tmp/next-install-2a83162188099cf9e9368e898c11b52cfa3ffabf1f7727b2d413b5b9da454185/node_modules/.pnpm/file+..+..+work+packages+next+packed-next.tgz_biqbaboplfbrettd7655fr4n2y/node_modules/next/dist/server/next-server.js:468:47)
  "
  at Object.<anonymous> (e2e/fetch-failures-have-good-stack-traces-in-edge-runtime/fetch-failures-have-good-stack-traces-in-edge-runtime.test.ts:36:30)

Read more about building and testing Next.js in contributing.md.

@ijjk ijjk merged commit 5f937d6 into vercel:canary Jan 26, 2023
@ijjk ijjk deleted the ci/flakey-polyfills-acceptance-tests branch January 26, 2023 18:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Next.js team PRs by the Next.js team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants