Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Describe how to manually configure open telemetry #48071

Merged
merged 3 commits into from Apr 11, 2023

Conversation

jankaifer
Copy link
Contributor

@jankaifer jankaifer commented Apr 7, 2023

It's currently not clear that @vercel/otel is just a simple wrapper when you are trying things out. So I added an excellent example of how to instrument create an OpenTelemetry setup.

The only FUD I have here is that people won't skip that Manual OpenTelemetry setup and try to understand it. But I try to describe this at the beginning of that section.

I'll also try to update @vercel/otel readme to be more transparent on what it does.

@jankaifer jankaifer changed the title Also add manual OTEL configuration into docs Docs: Describe how to manually configure open telemetry Apr 7, 2023
@jankaifer jankaifer marked this pull request as ready for review April 7, 2023 11:35
@jankaifer jankaifer requested review from a team and leerob as code owners April 7, 2023 11:35
timneutkens
timneutkens previously approved these changes Apr 9, 2023
@jankaifer jankaifer added this pull request to the merge queue Apr 11, 2023
Merged via the queue into canary with commit af12a94 Apr 11, 2023
100 checks passed
@jankaifer jankaifer deleted the jankaifer/migrate-otel-to-node-sdk branch April 11, 2023 11:04
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants