Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow anyone to approve a lockfile change #48261

Merged
merged 3 commits into from Apr 12, 2023
Merged

allow anyone to approve a lockfile change #48261

merged 3 commits into from Apr 12, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented Apr 11, 2023

What?

web-tooling team can approve lockfile changes

Why?

updating turbopack requires to update the lockfile

How?

add lockfile to code owners

@sokra sokra requested a review from a team as a code owner April 11, 2023 17:52
@ijjk ijjk added the created-by: Turbopack team PRs by the turbopack team label Apr 11, 2023
.github/CODEOWNERS Outdated Show resolved Hide resolved
jankaifer
jankaifer previously approved these changes Apr 11, 2023
Co-authored-by: JJ Kasper <jj@jjsweb.site>
@sokra sokra enabled auto-merge April 11, 2023 18:06
@ijjk
Copy link
Member

ijjk commented Apr 11, 2023

Failing test suites

Commit: c2c1429

pnpm testheadless test/integration/app-document/test/index.test.js

  • Document and App > Rendering via HTTP > _document > It adds nonces to all scripts and preload links
Expand output

● Document and App › Rendering via HTTP › _document › It adds nonces to all scripts and preload links

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  42 |           if ($(element).attr('nonce') !== nonce) noncesAdded = false
  43 |         })
> 44 |         expect(noncesAdded).toBe(true)
     |                             ^
  45 |       })
  46 |
  47 |       test('It adds crossOrigin to all scripts and preload links', async () => {

  at Object.<anonymous> (integration/app-document/test/rendering.js:44:29)

Read more about building and testing Next.js in contributing.md.

@sokra sokra disabled auto-merge April 12, 2023 06:42
@sokra sokra merged commit b9618ea into canary Apr 12, 2023
99 of 102 checks passed
@sokra sokra deleted the sokra/owners branch April 12, 2023 06:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants