Exclude app from _devPagesManifest.js in turbopack
#48633
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ForsakenHarmony
requested review from
timneutkens,
ijjk,
shuding and
a team
as code owners
ijjk
added
Turbopack
sokra
reviewed
Apr 20, 2023
Comment on lines
+84
to
+88
| if !s.starts_with('/') { | ||
| format!("/{}", s) | ||
| } else { | ||
| s.to_string() | ||
| } |
There was a problem hiding this comment.
That seem to be hiding an inconsistency in get_pathname().
- Add a comment to
get_pathname()about the intended behavior (seems like with / should be always used) - Make all
get_pathnameimplementations run the correct format - Potentially assert here that it has a leading /
sokra
previously approved these changes
Apr 20, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Seems I accidentally included the app root when I initially added it, but apps never have a page loader, so they should be excluded
I also cleaned up the manifest a bit, and it now perfectly matches the one in next.js
Fixes WEB-926