Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update google fonts #48984

Merged
merged 1 commit into from Apr 29, 2023
Merged

Update google fonts #48984

merged 1 commit into from Apr 29, 2023

Conversation

huozhi
Copy link
Member

@huozhi huozhi commented Apr 29, 2023

What?

  • Update google fonts for next/font with scripts/update-google-fonts.js.
  • Add npm script pnpm update-google-fonts

How?

Run pnpm update-google-fonts

@ijjk ijjk added Font (next/font) Related to Next.js Font Optimization. created-by: Next.js team PRs by the Next.js team type: next labels Apr 29, 2023
ijjk
ijjk approved these changes Apr 29, 2023
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to setup a Cron job for this when we have a chance

@kodiakhq kodiakhq bot merged commit 986039d into vercel:canary Apr 29, 2023
92 checks passed
@huozhi huozhi deleted the update-google-fonts branch April 29, 2023 15:33
@timneutkens timneutkens mentioned this pull request Apr 29, 2023
Closed
@funwarioisii funwarioisii mentioned this pull request May 29, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@timneutkens timneutkens Awaiting requested review from timneutkens timneutkens is a code owner

@shuding shuding Awaiting requested review from shuding shuding is a code owner

@feedthejim feedthejim Awaiting requested review from feedthejim feedthejim is a code owner

Assignees
No one assigned
Labels
created-by: Next.js team PRs by the Next.js team Font (next/font) Related to Next.js Font Optimization. type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huozhi @ijjk