fix GlobalError interop and add test case #49033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
added
Turbopack
sokra
added a commit
to vercel/turbo
that referenced
this pull request
May 1, 2023
### Description Proxy modules must not use interop logic, otherwise only the `default` export works correctly next.js PR: vercel/next.js#49033
sokra
force-pushed
the
sokra/default-import-client-component
branch
from
aa6727e
to
acdcad8
Compare
sokra
force-pushed
the
sokra/default-import-client-component
branch
from
acdcad8
to
eedd97c
Compare
sokra
requested review from
timneutkens,
ijjk,
shuding,
a team,
huozhi and
feedthejim
as code owners
timneutkens
approved these changes
May 1, 2023
alexkirsz
approved these changes
May 1, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
fixes handling of GlobalError interop
adds a test case for client component bug
Why?
app dir client component interop is broken
Turbopack changes