Fix serving images referenced from app directory #49236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jridgewell
requested review from
timneutkens,
ijjk,
shuding and
a team
as code owners
ijjk
added
Turbopack
ForsakenHarmony
approved these changes
May 4, 2023
sokra
approved these changes
May 4, 2023
kodiakhq bot
pushed a commit
that referenced
this pull request
May 10, 2023
### What? Regression test for #49236 ### Why? ### How?
3 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes serving images that are referenced by JS files inside the
/appdirectory.Why?
How?
The
NextImageContentSourceattempts to fetch the image out of it's inner content source, and before we were only providing it with the/publicand/pagesdirectory's respective sources.Re: https://vercel.slack.com/archives/C046HAU4H7F/p1683220799917649