Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update test snapshots #50159

Merged
merged 1 commit into from May 22, 2023
Merged

update test snapshots #50159

merged 1 commit into from May 22, 2023

Conversation

sokra
Copy link
Member

@sokra sokra commented May 22, 2023

What?

follow up for #50137

Why?

I accidentally merged the PR with broken tests

@sokra sokra requested review from timneutkens, ijjk, shuding and a team as code owners May 22, 2023 12:27
@ijjk ijjk added Turbopack Related to Turbopack with Next.js. created-by: Turbopack team PRs by the turbopack team type: next labels May 22, 2023
@sokra sokra requested a review from kdy1 May 22, 2023 12:27
@ijjk
Copy link
Member

ijjk commented May 22, 2023

Failing test suites

Commit: 8361f6a

pnpm testheadless test/integration/clean-distdir/test/index.test.js

  • Cleaning distDir > disabled write > should not clean up .next before build start
  • Cleaning distDir > server mode > should clean up .next before build start
Expand output

● Cleaning distDir › server mode › should clean up .next before build start

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  20 |   // `.next/cache` should be preserved in all cases
  21 |   expect(fs.existsSync(cacheDir)).toBe(true)
> 22 |   expect(fs.existsSync(swcCacheDir)).toBe(true)
     |                                      ^
  23 | }
  24 |
  25 | const runTests = () => {

  at checkFileWrite (integration/clean-distdir/test/index.test.js:22:38)
  at Object.<anonymous> (integration/clean-distdir/test/index.test.js:27:5)

● Cleaning distDir › disabled write › should not clean up .next before build start

expect(received).toBe(expected) // Object.is equality

Expected: true
Received: false

  20 |   // `.next/cache` should be preserved in all cases
  21 |   expect(fs.existsSync(cacheDir)).toBe(true)
> 22 |   expect(fs.existsSync(swcCacheDir)).toBe(true)
     |                                      ^
  23 | }
  24 |
  25 | const runTests = () => {

  at checkFileWrite (integration/clean-distdir/test/index.test.js:22:38)
  at Object.<anonymous> (integration/clean-distdir/test/index.test.js:53:7)

Read more about building and testing Next.js in contributing.md.

@sokra sokra merged commit 309bfdb into canary May 22, 2023
96 of 97 checks passed
@sokra sokra deleted the sokra/update-snapshots branch May 22, 2023 12:50
hydRAnger pushed a commit to hydRAnger/next.js that referenced this pull request Jun 12, 2023
### What?

follow up for vercel#50137

### Why?

I accidentally merged the PR with broken tests
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
created-by: Turbopack team PRs by the turbopack team Turbopack Related to Turbopack with Next.js. type: next
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants