Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cypress component testing - fixes #50283 #50303

Merged
merged 10 commits into from Jun 14, 2023

Conversation

ciruz
Copy link
Contributor

@ciruz ciruz commented May 24, 2023

What?

Fixing the cypress component testing example, since it breaks the next.js build process.

Why?

The default example is not working regarding this issue: #50283

Because there's a cypress test file (*.cy.tsx) inside the /pages directory.

How?

In this pull request, I made the following changes:

  • Removed the new Cypress component test file from the /pages directory to resolve conflicts with the build process.
  • Created a dedicated directory for components, and created a new example component.
  • Moved the test file to the new component directory to ensure it works as expected.

Build works:

image

Starting the new component testing works:

image

Cypress Component Testing starts correctly:

image

The Component Test is there and ready to test:

image

The Component Test passed as expected:

image

@ciruz ciruz requested review from a team, leerob and steven-tey as code owners May 24, 2023 20:31
@ijjk ijjk added the examples Issue/PR related to examples label May 24, 2023
@ijjk
Copy link
Member

ijjk commented May 31, 2023

Allow CI Workflow Run

  • approve CI run for commit: 0e40a06

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit 6f9c9ad into vercel:canary Jun 14, 2023
31 checks passed
@ciruz ciruz deleted the fix-with-cypress-component-example branch June 15, 2023 07:03
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants