Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix deprecated configureStore in with-redux-saga example #50342

Merged
merged 7 commits into from Jun 14, 2023
Merged

fix deprecated configureStore in with-redux-saga example #50342

merged 7 commits into from Jun 14, 2023

Conversation

kijikunnn
Copy link
Contributor

This PR introduces the following changes:

  • Replaced redux's deprecated createStore with configureStore from @reduxjs/toolkit.
  • Updated packages.
  • Corrected an error in getStaticProps.

This is my first contribution and there may be some shortcomings, I appreciate your understanding and look forward to your feedback.

@kijikunnn kijikunnn requested review from a team, leerob and steven-tey as code owners May 25, 2023 14:50
@ijjk ijjk added the examples Issue/PR related to examples label May 25, 2023
ijjk
ijjk approved these changes Jun 14, 2023
View reviewed changes
Copy link
Member

@ijjk ijjk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ijjk ijjk merged commit d080c8e into vercel:canary Jun 14, 2023
31 checks passed
@kijikunnn kijikunnn deleted the update-with-redux-saga-example branch June 15, 2023 00:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ijjk ijjk ijjk approved these changes

@leerob leerob Awaiting requested review from leerob

@steven-tey steven-tey Awaiting requested review from steven-tey

Assignees
No one assigned
Labels
examples Issue/PR related to examples locked
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kijikunnn @ijjk