Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix with typescript stripe example fixes #50541 #50574

Merged
merged 12 commits into from Jun 14, 2023

Conversation

ciruz
Copy link
Contributor

@ciruz ciruz commented May 31, 2023

What?

The TypeScript Stripe example has been fixed to address various issues. One of the issues was related to calling a function, which has now been resolved. Additionally, the Stripe API used in the example was outdated, causing an error during the build process. This issue has also been fixed.

By making these fixes, the TypeScript Stripe example should now work correctly without any function calling issues or errors related to the outdated Stripe API during the build.

Why?

There's an issue regarding this problem Fix with typescript stripe example fixes #50541

$ next build
- info Linting and checking validity of types ..- error ESLint must be installed in order to run during builds: yarn add --dev eslint
- info Linting and checking validity of types ...Failed to compile.

./components/CartSummary.tsx:41:24
Type error: Argument of type '{ sessionId: any; }' is not assignable to parameter of type 'string'.

  39 |     }
  40 |
> 41 |     redirectToCheckout({ sessionId: response.id })
     |                        ^
  42 |   }
  43 |
  44 |   return (
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

How?

image

@ciruz ciruz requested review from a team, leerob and steven-tey as code owners May 31, 2023 08:18
@ijjk ijjk added the examples Issue/PR related to examples label May 31, 2023
@ijjk
Copy link
Member

ijjk commented May 31, 2023

Allow CI Workflow Run

  • approve CI run for commit: f7d6d00

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

leerob
leerob previously approved these changes Jun 1, 2023
Copy link

@CharlesCCC CharlesCCC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test it with vercel site, it is all working fine now. thank you.

ijjk
ijjk previously approved these changes Jun 14, 2023
@ijjk ijjk dismissed stale reviews from leerob and themself via 43f9937 June 14, 2023 04:38
@kodiakhq kodiakhq bot merged commit a59c1f0 into vercel:canary Jun 14, 2023
32 checks passed
@ciruz ciruz deleted the fix-with-typescript-stripe-example branch June 15, 2023 07:02
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
examples Issue/PR related to examples locked
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants