Update PR stats workflow #50853
Merged
Update PR stats workflow #50853
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ijjk
force-pushed
the
update/pr-stats
branch
5 times, most recently
from
1458849
to
d464465
Compare
styfle
reviewed
Jun 6, 2023
|
Looks like CI is failing Maybe because its a fork? |
|
That occasionally happens from timing out during cloning the different branches, have an optimization for that I'm gonna open a follow-up for |
styfle
previously approved these changes
Jun 6, 2023
|
ijjk
added a commit
that referenced
this pull request
Jun 6, 2023
Follow-up to #50853 this optimizes how we clone the branches for generating stats. Before: https://github.com/vercel/next.js/actions/runs/5191059058/jobs/9358459062 21min After: https://github.com/vercel/next.js/actions/runs/5191282140/jobs/9358934393?pr=50859 11min
This was referenced Jun 6, 2023
ijjk
added a commit
that referenced
this pull request
Jun 7, 2023
This fixes the wasm swc build being used for PR stats unexpectedly since pnpm pack wasn't actually including the swc binary. This also adds a hard error preventing the wasm swc binary from being leveraged in the future for PR stats. x-ref: [vercel/next.js/actions/runs/5193512579/jobs/9364168639](https://github.com/vercel/next.js/actions/runs/5193512579/jobs/9364168639) x-ref: #50853 (comment) --------- Co-authored-by: Steven <steven@ceriously.com>
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
Updates to re-use our build workflow so turbo remote cache is leveraged and updates re-usable workflow reference to be the same branch instead of main.
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
Follow-up to vercel#50853 this optimizes how we clone the branches for generating stats. Before: https://github.com/vercel/next.js/actions/runs/5191059058/jobs/9358459062 21min After: https://github.com/vercel/next.js/actions/runs/5191282140/jobs/9358934393?pr=50859 11min
hydRAnger
pushed a commit
to hydRAnger/next.js
that referenced
this pull request
Jun 12, 2023
This fixes the wasm swc build being used for PR stats unexpectedly since pnpm pack wasn't actually including the swc binary. This also adds a hard error preventing the wasm swc binary from being leveraged in the future for PR stats. x-ref: [vercel/next.js/actions/runs/5193512579/jobs/9364168639](https://github.com/vercel/next.js/actions/runs/5193512579/jobs/9364168639) x-ref: vercel#50853 (comment) --------- Co-authored-by: Steven <steven@ceriously.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates to re-use our build workflow so turbo remote cache is leveraged and updates re-usable workflow reference to be the same branch instead of main.